Skip to content

Commit

Permalink
Fixed bug when downloading unusual categories
Browse files Browse the repository at this point in the history
  • Loading branch information
saeedamen committed Oct 7, 2021
1 parent 4a72b99 commit 0c33429
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 2 additions & 0 deletions README.md
Expand Up @@ -117,6 +117,7 @@ individual data providers)

# Release Notes

* 0.1.26 - findatapy (07 Oct 2021)
* 0.1.25 - findatapy (07 Oct 2021)
* 0.1.24 - findatapy (06 Oct 2021)
* 0.1.23 - findatapy (03 Jun 2021)
Expand All @@ -135,6 +136,7 @@ individual data providers)
# Coding log

* 07 Oct 2021
* Fixed bug in downloading data for unusual categories
* Fixed missing ticker in time_series_tickers.csv
* 27 Sep 2021
* Fixed bug in numeric conversion in DataFrame
Expand Down
7 changes: 4 additions & 3 deletions findatapy/market/market.py
Expand Up @@ -366,8 +366,8 @@ def fetch_market(self, md_request=None, md_request_df=None, md_request_str=None,
# the idea is that we do all the market data downloading here, rather than elsewhere

# By default: pass the market data request to MarketDataGenerator
if data_frame is not None:
data_frame = None
# if data_frame is not None:
# data_frame = None

if data_frame is None:
data_frame = self._market_data_generator.fetch_market_data(md_request)
Expand All @@ -378,7 +378,8 @@ def fetch_market(self, md_request=None, md_request_df=None, md_request_str=None,

# Push into cache
if md_request.push_to_cache:
self.speed_cache.put_dataframe(key, data_frame)
if data_frame is not None:
self.speed_cache.put_dataframe(key, data_frame)

return data_frame

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Expand Up @@ -5,7 +5,7 @@
tickers, using configuration files. There is also functionality which is particularly useful for those downloading FX market data."""

setup(name='findatapy',
version='0.1.25',
version='0.1.26',
description='Market data library',
author='Saeed Amen',
author_email='saeed@cuemacro.com',
Expand Down

0 comments on commit 0c33429

Please sign in to comment.