Update deprecated method - Scenario.embed() to Scenario.attach() "Fixes #486"

[josepj]

5.7.0 (2020-05-01)
Added
[Java] Scenario.log(String) & Scenario.attach(byte[], String, String) (#1893 Tim te Beek)
Deprecated
[Java] Scenario.write(String) & Scenario.embed(byte[], String, String) (#1893 Tim te Beek)

[luke-hill]

Could you scan the doc for all instances of this in all languages. As it makes sense to fix them all up now (They're all updated).

[josepj]

@luke-hill, thanks for looking into this. I looked through the docs and could find only one other instance of embed, for Ruby. I have updated the code, but I am not familiar with Ruby. So please review the change.

4.0.0.rc.4
Added
Methods log and attach can be used in step definitions to attach text or images
Deprecated
embed in step definitions in favor of attach (cucumber#897)

[mlvandijk]

LGTM but I have not scanned the project for other instances.

[mlvandijk]

Does this fix #486? If so, please make sure that gets closed on merge (iirc you can do so automatically by adding "Fixes #486" to the name of the PR)

[aslakhellesoy]

Hi @josepj,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber