Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Layout rubocop fixes #235

Merged
merged 16 commits into from
Oct 6, 2023
Merged

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

Bunch of simple layout fixes

⚡️ What's your motivation?

All autofixes, clear a lot of the low-hanging fruit

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill
Copy link
Contributor Author

@mpkorstanje whilst doing some very basic refactoring / linting here. I noticed we have a situation in which we want to define a method called end

I imagine in other languages it's a similar issue. But it would be good if we could maybe change this to something like ending. Whilst it's not 100% invalid to be called end it often cannot be parsed or read as it's understood to be a keyword definition. There are a few small exceptions in ruby - such as using send("end") to call it using metaprogramming.

Given you've done most of the work here recently, other than Aslak I figured I'd ask you for your thoughts.

I also noticed that we seem to refer to the iVar @end in some hashable methods e.t.c. - So maybe we can just do away with the methods completely (i.e. delete #end alongside all the other methods?) I don't know as I only spent 5mins diving in here.

@luke-hill
Copy link
Contributor Author

I've raised an issue here: #236 to discuss this in more detail

@luke-hill luke-hill merged commit 82b3869 into main Oct 6, 2023
26 checks passed
@luke-hill luke-hill deleted the refactor/rubocop_autofixes_part2 branch October 6, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant