Allow multiple arguments to xProcess#write #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
approved these changes
Jun 1, 2019
lib/aruba/processes/basic_process.rb
Outdated
| end | ||
|
|
||
| def stderr(*) | ||
| NotImplementedError | ||
| raise NotImplementedError |
| @@ -99,12 +99,11 @@ def stderr(*) | |||
| @stderr.string | |||
| end | |||
|
|
|||
| # Write strint to stdin | |||
| # Write strings to stdin | |||
| it 'it shows useful info' do | ||
| expected = /#<#<Class:0x[0-9A-Fa-f]+>:\d+ commandline="foobar": stdout="foo output" stderr="foo error output"/ | ||
| expect(subject.inspect).to match(expected) | ||
| expect(derived_process.inspect).to match(expected) |
There was a problem hiding this comment.
This is a neat update to the expect() clauses.
luke-hill
reviewed
Jul 1, 2019
| @@ -186,7 +186,7 @@ def run_command_and_stop(cmd, opts = {}) | |||
| def type(input) | |||
| return close_input if input == "\u0004" | |||
|
|
|||
| last_command_started.write(input << "\n") | |||
| last_command_started.write(input, "\n") | |||
There was a problem hiding this comment.
This probably needs to enumerate something like
input.times do |item|
last_command_started.write(item, "\n")
end
mvz
force-pushed
the
improve-process-write
branch
from
209f183
to
212c690
Compare
mvz
force-pushed
the
improve-process-write
branch
from
212c690
to
04fe34f
Compare
Co-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
mvz
force-pushed
the
improve-process-write
branch
from
04fe34f
to
8fde296
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow passing more than one string to
InProcess#writeandSpawnProcess#writeDetails
Changes the arity of these two methods to match that of the base class' method. This makes these methods match the behavior of
IO#write.Motivation and Context
This avoids the need to do a string append in
Api::Commands#type, which in turn will help avoid issues when frozen strings are passed to that method. As a next step, all strings in Aruba can be made frozen by default.How Has This Been Tested?
Specs have been added
Types of changes
Checklist: