Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TCP_NODELAY on connections #5558

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mjagdis
Copy link
Contributor

@mjagdis mjagdis commented Apr 29, 2024

Fixes #5065

Minecraft/cuberite does its own buffering at the app layer and there's little point holding back a trailing partial packet.

Signed-off-by: Mike Jagdis <mjagdis@eris-associates.co.uk>
Signed-off-by: Mike Jagdis <mjagdis@eris-associates.co.uk>
Signed-off-by: Mike Jagdis <mjagdis@eris-associates.co.uk>
Copy link
Member

@bearbin bearbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @12xx12 any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate TCP_NODELAY
2 participants