fix: #5542 Fixing damage on Teleport #5544
Conversation
|
should close : #5286 |
|
@bearbin there seem to be a broblem with the CI (git not installed or something) and I heard that you are the one in charge ^^ can you take a look ? |
|
OK that was a bizarre problem, somehow it had just got stuck and refused to actually try a build. Restarting solved it though, so it's all good now :) |
Head branch was pushed to by a user without write access
|
tbh I don't really know how to add the bindings ^^ |
|
Add it in the APIDump plugin into the APIDesc.lua file. Search for the other functions from cPawn |
Reseting the LastGroundHeight on teleport Using inheritence for teleporting to avoid rewriting code
tonitch
force-pushed
the
tonitch/fix/#5542-teleport-damage-fix
branch
from
3ebf66f
to
d0bbba7
Compare
| @@ -9829,6 +9829,25 @@ a_Player:OpenWindow(Window); | |||
| }, | |||
| Notes = "Removes a currently applied entity effect", | |||
| }, | |||
| TeleportToCoords = | |||
There was a problem hiding this comment.
I have two questions/concerns:
- How do the API docs handle this override? Do we have other cases where we do this?
- Can this export ever be reverted in the future if necessary, without breaking things?
It's been a while since I touched any of this. If everything is fine, feel free to dismiss this comment.
There was a problem hiding this comment.
I honestly don't know how this api export works ^^ I though it would be better to use inheritence in this patch but it's indeed not strictly necessary so I can just do a dirty patch instead ^^
Reseting the LastGroundHeight on teleport
Using inheritence for teleporting to avoid rewriting code
fix: #5542 (and potentialy other)