Block Handler include processing for block states #5490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Block types with multiple instances (slabs, fences, ...) have unified methods to find out about their state - renamed crafting table and wool block handler
|
newly undocumented symbols |
madmaxoft
reviewed
May 25, 2023
| Type = "eBlockFace", | ||
| }, | ||
| }, | ||
| Notes = "Returns the {{Globals#BlockFaces|eBlockFace}} that corresponds to the given {{Globals#BlockFaces|eBlockFace}} after mirroring it around the XY plane (or rotating 180 degrees around it).", |
There was a problem hiding this comment.
So is it mirroring or rotating? In the general sense, those two operations are different, though for Minecraft they may be the same?
There was a problem hiding this comment.
Indeed, this comment is wrong.
For most blocks, this applies. But if you want to rotate blocks with the ability to be asymmetric you don't have 180 degree rotation but mirroring. For examples vines.
Example viewed from the top:
_| should mirror to |_ but rotation does yield |^. Imagine the ^ is a horizontal line at the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of the Block State PR. I try to split up my 31k line PR into more sensible parts.
In the end, this just enlarges the executable with stale code xD