Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underlying Datatype of Fluid simulator is now smart pointer and array #5489

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

12xx12
Copy link
Member

@12xx12 12xx12 commented Apr 8, 2023

  • ChunkData is now stored in a smart pointer
  • added constant for falling bit

- ChunkData is now stored in a smart pointer
- added constant for falling bit
@12xx12
Copy link
Member Author

12xx12 commented Apr 13, 2023

Finnaly a PR that reduces the toal line count xD

src/Simulator/DelayedFluidSimulator.h Outdated Show resolved Hide resolved
src/Simulator/FloodyFluidSimulator.cpp Outdated Show resolved Hide resolved
src/Simulator/FloodyFluidSimulator.cpp Outdated Show resolved Hide resolved
src/Simulator/NoopFluidSimulator.h Outdated Show resolved Hide resolved
src/Simulator/NoopFluidSimulator.h Outdated Show resolved Hide resolved
src/Simulator/NoopFluidSimulator.h Outdated Show resolved Hide resolved
src/Simulator/VanillaFluidSimulator.h Outdated Show resolved Hide resolved
src/Simulator/VaporizeFluidSimulator.h Outdated Show resolved Hide resolved
@12xx12 12xx12 added this to the C++11 conversion milestone Sep 25, 2023
@12xx12 12xx12 requested a review from madmaxoft October 2, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants