Now using size_t in item grids and accompanying classes #5478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As STL-Containers want to use unsigned indexes it is better to migrate everything to size_t in the long run to avoid static_cast's. Signed integers may still be used for special indexes, which may have some special values, e.g. -1 if no index was found. This has the benefit that the compiler will throw an error, if somebody always valid indexes and indexes that may have a special value, as both distinguish in the signedness.
|
This breaks plugins, as they expect |
|
(╯°□°）╯︵ ┻━┻ |
|
So, how do we deal with this?
|
|
Why use size_t at all for slots when we know slot index will always fit into a single byte (or maybe into a short to be on the safe side). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well that escalated quickly.
This PR takes over #4979. And changes cItemGrid completely to use
std::size_tto index everything. Since -1 was used to indicate illegal slot stuff, the best alternative seemsstd::numeric_limits<std::size_t>::max()