Explosions: improve performance #5435
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearbin
reviewed
Aug 6, 2022
Comment on lines
+76
to
+99
| // Clamp the start coords into the world by advancing them along the line: | ||
| if (a_Start.y < 0) | ||
| { | ||
| if (a_End.y < 0) | ||
| { | ||
| // Nothing to trace: | ||
| a_Callbacks.OnNoMoreHits(); | ||
| return true; | ||
| } | ||
|
|
||
| a_Start = FixStartBelowWorld(a_Start, a_End); | ||
| a_Callbacks.OnIntoWorld(a_Start); | ||
| } | ||
| else if (a_Start.y >= cChunkDef::Height) | ||
| { | ||
| if (a_End.y >= cChunkDef::Height) | ||
| { | ||
| a_Callbacks.OnNoMoreHits(); | ||
| return true; | ||
| } | ||
|
|
||
| a_Start = FixStartAboveWorld(a_Start, a_End); | ||
| a_Callbacks.OnIntoWorld(a_Start); | ||
| } |
There was a problem hiding this comment.
This can have it's very own function :)
|
I have some minor updates for this one, but first I will make #5434 ready, which this branch depends on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Release, Windows ia32, 17³ sphere of TNT created with WorldEdit.
Summary: changes reduce time for TPS to recover by 39% when no pickup entities are spawned, and make the server not freeze compeltely when pickup entities are spawned. The changes achieve this by coalescing pickup spawns during explosions, improving pickup behaviour not to do unnecessary work when idle, and improving block tracer performance.
Below are the tests I ran. Screenshots taken without pickup spawns since the client couldn't handle it otherwise.
Prior (with pickup spawns). Server doesn't recover due to tens of thousands of pickup entities, test stopped at 2 min 25 sec.
Prior (without pickups). Server recovers in 56 sec.
Prior blast result.
After (with pickup spawns). Server recovers to 19.68 TPS after 51 sec, but with high CPU load.
After (without pickups). Server recovers in 34 sec.
After blast result.
