Adding to code to support repository-settings#711

ctoestreich · Feb 5, 2024 · 1d49f40 · 1d49f40
1 parent 9ec4069
commit 1d49f40
Show file tree

Hide file tree

Showing 3 changed files with 79 additions and 37 deletions.
diff --git a/lib/plugins/environments.js b/lib/plugins/environments.js
@@ -96,6 +96,21 @@ module.exports = class Environments extends Diffable {
         )
       )
     }
+    if (attrs.variables) {
+      // perhaps this should be retrieved on init so that repo context is more broadly hydrated and not just for this one call
+      const repository = await this.getRepository(this.repo.owner, this.repo.repo)
+      if (repository && repository.id) {
+        await Promise.all(
+          Object.entries(attrs.variables).map(([name, value]) =>
+            this.github.request('POST /repositories/:repository_id/environments/:environment_name/variables', {
+              repository_id: repository.id,
+              environment_name: attrs.name,
+              name,
+              value
+            })
+          ))
+      }
+    }
   }
 
   remove (existing) {
@@ -151,6 +166,16 @@ module.exports = class Environments extends Diffable {
     return branchPolicies
   }
 
+  async getRepository (org, repo) {
+    const {
+      data
+    } = await this.github.request('GET /repos/:org/:repo', {
+      org,
+      repo
+    })
+    return data
+  }
+
   toParams (existing, attrs) {
     const deploymentBranchPolicy = attrs.deployment_branch_policy
       ? this.shouldUseProtectedBranches(

diff --git a/package-lock.json b/package-lock.json
diff --git a/test/unit/lib/plugins/environments.test.js b/test/unit/lib/plugins/environments.test.js
@@ -5,6 +5,7 @@ describe('Environments', () => {
   let github
   const org = 'bkeepers'
   const repo = 'test'
+  const repoId = 12345
 
   function configure (config) {
     return new Environments(github, { owner: org, repo }, config)
@@ -42,6 +43,10 @@ describe('Environments', () => {
           ],
           deployment_branch_policy: {
             custom_branches: ['dev/*', 'dev-*']
+          },
+          variables: {
+            FOO: 'bar',
+            FIZZ: 'buzz'
           }
         },
         {
@@ -66,6 +71,23 @@ describe('Environments', () => {
         { name: 'Different-case', wait_timer: 0 }
       ])
 
+      when(github.request)
+        .calledWith('GET /repos/:org/:repo', {
+          org,
+          repo
+        }).mockResolvedValue({
+          data: {
+            id: repoId,
+            node_id: 'A_bcdefghijk',
+            name: repo,
+            full_name: `${org}/${repo}`,
+            private: true,
+            owner: {
+              login: org
+            }
+          }
+        })
+
       when(github.request)
         .calledWith('GET /repos/:org/:repo/environments', { org, repo })
         .mockResolvedValue({
@@ -215,6 +237,26 @@ describe('Environments', () => {
           }
         })
 
+        expect(github.request).toHaveBeenCalledWith(
+          'POST /repositories/:repository_id/environments/:environment_name/variables',
+          {
+            repoId,
+            environment_name: 'new-environment',
+            name: 'FOO',
+            value: 'bar'
+          }
+        )
+
+        expect(github.request).toHaveBeenCalledWith(
+          'POST /repositories/:repository_id/environments/:environment_name/variables',
+          {
+            repoId,
+            environment_name: 'new-environment',
+            name: 'FIZZ',
+            value: 'buzz'
+          }
+        )
+
         expect(github.request).toHaveBeenCalledWith('DELETE /repos/:org/:repo/environments/:environment_name', {
           org,
           repo,