FormData multi-part handling #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgalon
force-pushed
the
form-data
branch
3 times, most recently
from
45b11be
to
ab34875
Compare
marcbachmann
reviewed
Apr 1, 2021
| @@ -64,6 +64,26 @@ function isParametersMatching(parameters, required) { | |||
| } | |||
|
|
|||
| function isBodyMatching(body, requiredBody) { | |||
| if (requiredBody instanceof FormData) { | |||
There was a problem hiding this comment.
instanceof checks won't work as only one specific version of the module would be handled.
This would probably need some kind of duck typing.
Also, FormData isn't global in node <18.0.0, so this will break the module for older versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.