Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail if nltk downloads don't work #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ysgit
Copy link

@ysgit ysgit commented Jan 8, 2019

hi @csurfer, thanks for your work here!

I found I had to make this change in order to be able to be able to install the package as part of a serverless app to deploy on AWS lambda. In that context it doesn't really make sense to force download the NLTK data as part of the install of your package. In fact, the install failed because it didn't have access to nlltk at build time.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.773% when pulling d2570b5 on ysgit:setup-without-nltk into e36116d on csurfer:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.773% when pulling d2570b5 on ysgit:setup-without-nltk into e36116d on csurfer:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.773% when pulling d2570b5 on ysgit:setup-without-nltk into e36116d on csurfer:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.773% when pulling d2570b5 on ysgit:setup-without-nltk into e36116d on csurfer:master.

@ysgit
Copy link
Author

ysgit commented Feb 12, 2019

hey @csurfer did you get the chance to take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants