Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index): don't scope imported selector classes #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apexskier
Copy link

@apexskier apexskier commented Jun 23, 2017

This is part of an overall resolution to css-modules/icss#12

I've got a PR coming to for https://github.com/webpack-contrib/css-loader that will enable this there as well. webpack-contrib/css-loader#562

@michael-ciniawsky michael-ciniawsky changed the title Don't scope imported selector classes fix(index): don't scope imported selector classes Jun 23, 2017
@TrySound
Copy link
Member

@apexskier Do you use low level API to process modules? We have postcss-icss-values for this. And this package has messages contracts with values.

@apexskier
Copy link
Author

My full setup uses css-loader. Does postcss-icss-values replace selector information? In my tests it doesn't appear to, both when run before and after postcss-icss-selectors in the postcss pipeline.

With or without postcss-icss-values, I think this is valuable, as it provides deeper conformance to the base css-modules spec (as I interpreted it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants