Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed unescapeString in the same manner as google chrome. #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

t-nakatsu-mf
Copy link

@t-nakatsu-mf t-nakatsu-mf commented Oct 25, 2017

Trailing space is unicode terminator, to be deleted.
'hei\DF en' -> 'heißen'
'hei\00DF en' -> 'heißen'
'hei\0000DF en' -> 'heißen'

Six characters of the unicode without terminator.
'hei\0000DFen' -> 'heißen'

Non hex-character is unicode terminator, to be passed.
'hei\DFt' -> 'heißt'

@codecov-io
Copy link

codecov-io commented Oct 25, 2017

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         258    257    -1     
  Branches       64     63    -1     
=====================================
- Hits          258    257    -1
Impacted Files Coverage Δ
lib/parseValues.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d315d8d...f4c9e06. Read the comment docs.

Trailing space is unicode terminator, to be deleted.
'hei\DF en' -> 'heißen'
'hei\00DF en' -> 'heißen'
'hei\0000DF en' -> 'heißen'

Six characters of the unicode without terminator.
'hei\0000DFen' -> 'heißen'

Non hex-character is unicode terminator, to be passed.
'hei\DFt' -> 'heißt'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants