Remove use of backtick execution #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…binary" as a test dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current use of backticks doesn't pose an immediate risk, however in general it's best to avoid them where possible. One of the projects I'm working on blocks all exec calls using backticks which is part of the reason I'm raising this PR.
I'll leave this PR in draft in the hopes the following PR gets merged: #131 if it doesn't get merged I'm happy to update this PR to use the old version of RSpec.
Changes
Testing
Installed the gem locally and generated an image from HTML and observed that the image generated correctly.