Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify mp3in and mp3len to use libsndfile #1785

Open
kunstmusik opened this issue Nov 10, 2023 · 4 comments
Open

Modify mp3in and mp3len to use libsndfile #1785

kunstmusik opened this issue Nov 10, 2023 · 4 comments
Assignees
Milestone

Comments

@kunstmusik
Copy link
Member

Regarding #1553, this is a story for removing custom mp3 code and replacing with libsndfile now that it has mp3 support.

@jpffitch
Copy link
Contributor

jpffitch commented Dec 20, 2023

Diskin2 includes mp3 input files. I have just built with the latest libsndfile and it runs the manual diskin2.csd with minimal modification to read the mp3 version of the drums. As it can do pitch shifting on reading the mp3 file it is better than mp3in.

Need to check mp3len

@vlazzarini
Copy link
Member

Thinking about this, I'd like to keep the specialist mp3 opcodes as it gives us a self-contained means of reading files without the need for dependencies.

Now that libsndfile can be taken out of the build, it seems a good idea to keep these.

@jpffitch
Copy link
Contributor

This can be closed. ?Only action needed is to consider optional inclusion of mp3in and kp3len.

@jpffitch jpffitch self-assigned this Jan 10, 2024
@jpffitch
Copy link
Contributor

jpffitch commented Mar 3, 2024

U a, cponfused hre.

Are you suggesing a plugik wiith jusr mp3in and its support code?#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants