Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: broken binding generation when unexposed enum in struct field #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: broken binding generation when unexposed enum in struct field #67

wants to merge 1 commit into from

Conversation

olbat
Copy link
Contributor

@olbat olbat commented Mar 1, 2020

Fixes #66

This was referenced Mar 1, 2020
Open
Closed
@RX14
Copy link
Contributor

RX14 commented Mar 7, 2020 •
edited

What code does this generate for the example in #66?

@olbat
Copy link
Contributor Author

olbat commented Mar 8, 2020

Here is the code that's generated with the patch:

lib LibTest
  fun  = test : St*
  struct St
    a : LibC::Int
    b : StB
  end
  enum StB
    X = 0
    Y = 1
  end
end

maxfierke added a commit to maxfierke/crystal_lib that referenced this pull request Apr 6, 2020
@maxfierke
Merge pull request crystal-lang#67 from olbat/fix-broken-binding-when…
ca7319b 
…-unexposed-enum-in-struct-field

Fix: broken binding generation when unexposed enum in struct field
@olbat
Copy link
Contributor Author

olbat commented Jun 12, 2020

Hey 👋 Can we consider to merge this fix now it's approved?

@WhoAteDaCake WhoAteDaCake mentioned this pull request Jun 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of unexposed enums leads to generation of broken bindings
2 participants
@olbat @RX14