Add standard Crossplane package labels to objects. #5536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the labels to the objects created by crossplane function and provider helps the end users to filter resources on these labels. Signed-off-by: Sunil Shivanand <padlar@live.com>
padlar
commented
Apr 3, 2024
| @@ -194,6 +195,7 @@ func (b *RuntimeManifestBuilder) Deployment(serviceAccount string, overrides ... | |||
| // Optional defaults, will be used only if the runtime config does not | |||
| // specify them. | |||
| DeploymentWithOptionalName(b.revision.GetName()), | |||
| DeploymentWithLabels(b.podSelectors()), | |||
There was a problem hiding this comment.
Not sure if adding it as an override is a good option. Other option is to add it in the runtime pre/post hook.
There was a problem hiding this comment.
I'm not sure either. @turkenh introduced this pattern, so I'm sure he can provide guidance.
negz
reviewed
Apr 3, 2024
| @@ -159,6 +159,7 @@ func (b *RuntimeManifestBuilder) ServiceAccount(overrides ...ServiceAccountOverr | |||
|
|
|||
| // Overrides that we are opinionated about. | |||
| ServiceAccountWithNamespace(b.namespace), | |||
| ServiceAccountWithLabels(b.podSelectors()), | |||
There was a problem hiding this comment.
Perhaps we should rename podSelectors if we're now using it to do more than select pods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the labels to the objects created by crossplane function and provider helps the end users to filter resources on these labels.
Description of your changes
Fixes #5273
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.