Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions/definition: wait for sync in composedResourceInformers #5468

Closed

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Mar 11, 2024

Pulled out from #5422.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • [ ] Added or updated unit tests.
  • Added or updated e2e tests.
  • [ ] Linked a PR or a docs tracking issue to document this change.
  • [ ] Added backport release-x.y labels to auto-backport this PR.

Need help with this checklist? See the cheat sheet.

@sttts sttts requested review from negz and a team as code owners March 11, 2024 07:27
@sttts sttts requested a review from phisco March 11, 2024 07:27
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
This reverts commit 53b143f.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
@sttts sttts force-pushed the sttts-realtime-compositions-wait-xr-sync branch from 95d7455 to 415c952 Compare March 11, 2024 07:30
@sttts sttts marked this pull request as draft March 11, 2024 07:40
@jbw976
Copy link
Member

jbw976 commented Mar 11, 2024

Is this also needed to address #5400? I didn't quickly find the reason it was pulled out from #5422, and I wanted to make sure that if this PR is also needed to fully address #5400 (which we want to include in a patch release once fixed), that we also backport this PR too 😊

@jbw976
Copy link
Member

jbw976 commented Apr 23, 2024

Any chance of more progress on this as v1.16 is approaching code freeze next week @sttts? If not, no worries, but did want to check in with you 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants