Ignore principals order when comparing policies #2058
Merged
+283
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
reviewed
May 13, 2024
There was a problem hiding this comment.
LGTM. @max-melentyev can you squash your changes in a single commit and adjust the commit message the follow the conventional commit guidelines (fix: ...)?
|
@max-melentyev can you rebase on the latest master and resolve the conflicts? |
AWS returns items in a random order so provider-aws should ignore it to not consider policies changed. Signed-off-by: Max Melentyev <max.melentyev@reddit.com>
|
rebased |
MisterMX
approved these changes
May 21, 2024
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-0.48
git worktree add -d .worktree/backport-2058-to-release-0.48 origin/release-0.48
cd .worktree/backport-2058-to-release-0.48
git checkout -b backport-2058-to-release-0.48
ancref=$(git merge-base c3eb9420eb473b04373268498172f238d4a349d3 626023f291247ffe75f114ea7e332fc0b2806e34)
git cherry-pick -x $ancref..626023f291247ffe75f114ea7e332fc0b2806e34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
AWS returns principals items in a random order so provider-aws should ignore it to not consider policies changed.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested