add(schema/dirs): refinement for linkDir being inside dataDirs #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaryS
previously approved these changes
May 14, 2024
mmgoodnow
reviewed
May 15, 2024
zakkarry
force-pushed
the
linkdir-in-datadir-check
branch
from
c063415
to
2d13494
Compare
zakkarry
force-pushed
the
linkdir-in-datadir-check
branch
from
2d13494
to
c2cf30a
Compare
mmgoodnow
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checks for linkDir being a child directory of a dataDir using resolve and relative from
path