permitCount values larger than 1 are now supported #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bb6baed024a4595a639085db09df954c90b064bf)
|
I've rebased this to align it with latest version from master. @cristipufu did you had a chance to take a look at it? Thx |
|
Hi @manuelspezzani please rebase again |
# Conflicts: # src/RedisRateLimiting/Concurrency/RedisConcurrencyManager.cs # src/RedisRateLimiting/FixedWindow/RedisFixedWindowManager.cs # src/RedisRateLimiting/SlidingWindow/RedisSlidingWindowManager.cs # src/RedisRateLimiting/TokenBucket/RedisTokenBucketManager.cs # test/RedisRateLimiting.Tests/UnitTests/SlidingWindowUnitTests.cs
|
@cristipufu done |
|
@cristipufu is there something blocking the merge here? We'd like to use this and stay in sync with upstream. |
|
@lofcz which rate limiter are you interested in? |
|
Fixed and Sliding window in our case @cristipufu |
|
Hey @cristipufu we're also interested in this (mainly for Sliding Window and Token Bucket). Thank you |
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #36
I had to slightly change some Lua scripts to take into account the permitCount value.