Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 128x64 #10

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

hackthis02
Copy link

Description

Added support for 128x64

Motivation and Context

This will allow users to use either a 128x32 or 64 size OLED display

How Has This Been Tested

I tested this with my RPi4 Home Assistant and a 128X64 OLED

Types of changes

  • 馃悰 Bug fix (non-breaking change which fixes an issue)
  • 馃殌 New feature (non-breaking change which adds functionality)
  • 馃寧 Translation (addition or update a translation)
  • 鈿狅笍 Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.

@rsnodgrass
Copy link
Contributor

Thanks @hackthis02 for the contribution!!

@RoLuWa
Copy link

RoLuWa commented May 25, 2024

Thanks @hackthis02 for the change!
But every other line on my display is dark.
A test with the same display on ESPhome works.
Do you have an explanation for this?
Display on Homeassistant
IMG_0725
Display on ESPhome
IMG_0728

@hackthis02
Copy link
Author

Have you checked the configuration? Confirmed you have it set for 128x64?
What is more likely is until @crismc accepts both of my PRs. The HA integration won't work since it's pointing at his pre-patched repo.

@crismc
Copy link
Owner

crismc commented May 27, 2024

PR conflicts with latest merge.
Happy to merge in once resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants