Drop support for path based seccomp profiles #7006
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7006 +/- ##
==========================================
- Coverage 49.21% 49.19% -0.02%
==========================================
Files 132 132
Lines 15381 15334 -47
==========================================
- Hits 7569 7544 -25
+ Misses 6909 6895 -14
+ Partials 903 895 -8 |
|
For critest this requires kubernetes-sigs/cri-tools#1181 |
saschagrunert
force-pushed
the
seccomp
branch
7 times, most recently
from
9a0bc39
to
4c6eff3
Compare
Field based profiles should be standard since many Kubernetes releases, means we can drop the path based logic and cleanup some code. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@sohankunkerkar looks like it's still using critest v1.27.0, do you have any idea how we can switch to |
We should merge this change as-is because the CI cache images still rely on v1.27.0. Alternatively, you can submit a different pull request by modifying the cri_tools_git_version. |
|
would you mind also tying in dropping traces of |
| @@ -12,7 +12,7 @@ build_kata: False | |||
| cgroupv2: False | |||
|
|
|||
| critest_mirror_repo: quay.io/crio | |||
| cri_tools_git_version: "v1.27.0" | |||
| cri_tools_git_version: master | |||
There was a problem hiding this comment.
any way this can be converted to "main"?
There was a problem hiding this comment.
Yes, when we agree on kubernetes-sigs/cri-tools#1100
I was thinking about it and re-added the behavior for the path based profiles in: I can follow-up on that PR and remove the feature since it's deprecated for a while now. |
|
@cri-o/ocicni-maintainers PTAL |
|
critest will fail until a new image is built /override ci/prow/ci-fedora-critest |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-fedora-critest, ci/prow/ci-rhel-critest In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/ci-fedora-critest |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-fedora-critest, ci/prow/ci-rhel-critest In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-gcp-ovn |
|
/override ci/prow/e2e-gcp-ovn |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Field based profiles should be standard since many Kubernetes releases, means we can drop the path based logic and cleanup some code.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?