config: allow overriding rutorrent scgi host and port #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain your use case for this change please? |
Initially I was planning to only utilize this container for rutorrent and have it connect to an already established rtorrent instance running natively on another box. This patch set allowed for that. A further patch set I had in my mind would be to add a way to disable running rtorrent (since in the above scenario, there's no reason to spin up an rtorrent instance that'll sit idle in the container). I've since changed my approach and don't really plan to use these anyway, so I'm indifferent on if you merge it. Just adds some more flexibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.