Update outputs of the CorrelatedJoin after the prunning #15969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaurzhanSakhariev
force-pushed
the
b/bug-fix
branch
from
5de6596
to
dd53930
Compare
BaurzhanSakhariev
changed the title
BaurzhanSakhariev
force-pushed
the
b/bug-fix
branch
2 times, most recently
from
122fb62
to
69c9a41
Compare
server/src/main/java/io/crate/planner/operators/CorrelatedJoin.java
Outdated
Show resolved
Hide resolved
mkleen
reviewed
May 8, 2024
BaurzhanSakhariev
force-pushed
the
b/bug-fix
branch
2 times, most recently
from
9eef99b
to
2c70ca9
Compare
BaurzhanSakhariev
force-pushed
the
b/bug-fix
branch
from
2c70ca9
to
7abd054
Compare
mfussenegger
approved these changes
May 22, 2024
server/src/test/java/io/crate/planner/CorrelatedJoinPlannerTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/io/crate/planner/CorrelatedJoinPlannerTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/io/crate/planner/CorrelatedJoinPlannerTest.java
Outdated
Show resolved
Hide resolved
BaurzhanSakhariev
force-pushed
the
b/bug-fix
branch
from
ee4d569
to
b287f4f
Compare
BaurzhanSakhariev
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15901
Make sure that CorrelatedJoin keeps its outputs in sync with underlying tree's outputs after the prunning.
Needed to avoid the situation when a column is referenced but not collected anymore.