Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error when USB CDC on Boot is enabled #2080

Merged

Conversation

k-takata
Copy link
Contributor

When USB CDC on Boot is enabled on ESP32-C3, an compilation error occurs, because Serial.begin() takes only one (or zero) parameter.

Check ARDUINO_USB_CDC_ON_BOOT and call it with the correct parameter.

When USB CDC on Boot is enabled on ESP32-C3, an compilation error
occurs, because `Serial.begin()` takes only one (or zero) parameter.

Check `ARDUINO_USB_CDC_ON_BOOT` and call it with the correct parameter.
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@crankyoldgit crankyoldgit merged commit 61b43de into crankyoldgit:master Mar 18, 2024
42 checks passed
@k-takata k-takata deleted the fix-compilation-error-usb-cdc branch March 18, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants