Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidies #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Tidies #86

wants to merge 2 commits into from

Conversation

hassankhan
Copy link
Contributor

What did you implement:

Minor tidies to serverless.yml.

How did you implement it:

Cleaned up extra whitespace and tidied the Fn::Join call.

How can we verify it:

By checking serverless.yml

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Tag ready for review or wip

Is this a breaking change?: NO/YES

@hassankhan
Copy link
Contributor Author

Seems the test passed but coverage failed 😕

@hassankhan
Copy link
Contributor Author

@jonsharratt could you possibly re-run the Travis tests for this PR? Given the changes I made, it shouldn't have failed the build 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant