better check for when we're falling back on a default BaseRelationField value #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrybrad
deleted the
bugfix/1432-better-check-for-falling-back-on-default-relation-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It’s already possible to import multiple values into fields that extend
BaseRelationField.In a case where in the feed you have a key with an empty array value, you map that empty array value to a
BaseRelationField, and you select a “Default ” too (on the mapping screen), the current check assumes you’ve set the feed value tonull, and fails when you’ve set it to an empty array. This PR improves this behaviour.Related issues
#1432