Fix Paid Status #3385
Open
Fix Paid Status #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the paid status issue by sometimes being overpaid or partially paid by converting the floats to ints, then doing the comparisons or arithmetic, altogether avoiding any float issues.
We just imported several hundred thousand orders from a legacy system into a new Commerce build, and this issue in #1836 was one of the issues we encountered while auditing the data migration. This solution resolves the issues in our sample size.
We were running 4.4.1.1.
Related issues
#1836
First Attempt: #1837