Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow trashed entries to be rendered when previewing #223

Merged
merged 3 commits into from May 14, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented May 9, 2024

Description

Allow trashed entries to be rendered when previewing.

Note: #222 is needed to see the nested entries in revisions.

Testing example:

  • have an entry type that contains a CKE field with the ability to nest entries in it (with revisions turned on for the section)
  • create a template for this section and ensure your CKE content is showing as expected (including rendering entries nested in the CKE field)
  • create an entry, add a nested entry to the CKE field & save
  • add a second nested entry to the CKE field & save
  • remove the first nested entry from the CKE field & save
  • go to the latest revision (revision 2 if you’re starting with a new entry) and see that you can see both nested entries showing in the revision
  • click “View” when in that revision and note that without this change, you can only see the second nested entry, despite the revision having both first and second in it

Related issues

@i-just i-just requested a review from brandonkelly as a code owner May 9, 2024 13:10
@brandonkelly brandonkelly merged commit b17e5e1 into 4.x May 14, 2024
@brandonkelly brandonkelly deleted the bugfix/render-trashed-entries-when-previewing branch May 14, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants