Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read config file path from TEAMSCALE_JAVA_PROFILER_CONFIG_FILE #425

Merged
merged 7 commits into from Apr 4, 2024

Conversation

karottenreibe
Copy link
Contributor

Addresses issue TS-38049

  • Changes are tested adequately
  • Agent's README.md updated in case of user-visible changes
  • CHANGELOG.md updated
  • Present new features in N&N
  • TGA Tutorial updated
  • TIA Tutorial updated

Please respect the vote of the Teamscale bot or flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.

Copy link
Contributor

@jveihelmann jveihelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Looks great and worked for me as expected.

Just nitpick comments from my side :)
Also, I would say to tolerate the Teamscale finding.

@karottenreibe karottenreibe merged commit ccf0aa5 into master Apr 4, 2024
7 checks passed
@karottenreibe karottenreibe deleted the ts/38049_config_file_env_variable branch April 4, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants