Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[108] eliminate tests skipping on windows #200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Doldrums
Copy link
Contributor

@Doldrums Doldrums commented Jun 1, 2022

Case is the following:

There are several tests ignored on windows, e.g. test_reads_git_author. These tests are ignored via "skip if Gem.win_platform?" but this makes it very difficult to develop, since you can not run the entire test suite.
Imho these tests should not be ignored and should be fixed.

May notice that there are not much strong differences in the commands for the terminal and Windows console; so we can correct this situation

@Doldrums
Copy link
Contributor Author

Doldrums commented Jun 1, 2022

Perhaps more specific comments are needed:

  • the only difference is in the structure of these terminal command tests
  • if you evaluate in detail what is being executed there: the error can only be on set -e
  • The ERRORLEVEL is already set, so there is no need to GOTO a label that sets the ERRORLEVEL.

@yegor256
Copy link
Member

@Doldrums can you please first help with this #204?

@Doldrums
Copy link
Contributor Author

Doldrums commented Jul 4, 2022

@yegor256 sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants