style: Convert EOL characters for .txt files from Windows CLRF to UNIX LF #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbyt
changed the title
robbyt
force-pushed
the
rterhaar/clrf
branch
2 times, most recently
from
33b8e3f
to
111f9de
Compare
robbyt
changed the title
|
Note for the reviewer, I've reduced the scope of this change to only fix the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
Currently, MemGPT has a mix of UNIX (LF) and Windows (CRLF) newline characters. This inconsistency could cause issues with source control and parsing text files.
How to test
This change should not cause any problems, because the Python runtime detects the newline encoding format.
Have you tested this PR?
I smoke-tested this change by running a the quickstart from MacOS, and it works as expected.
Is your PR over 500 lines of code?
I'm glad to split this up to multiple PRs. I fixed all code in the repo by running
find . -type f -name \*.txt -exec dos2unix {} \;but I can split this into smaller PRs if it's easier.