Allow setting the prompt via a commandline flag. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have users who want to customize what the prompt looks like, to include things like the git repo they are running in. Test plan: I ran: ``` % go run . -p "Huzzah> " // Welcome to gomacro. Type :help for help, :copy for copyright and license. // This is free software with ABSOLUTELY NO WARRANTY. Huzzah> ``` I also did: ``` % go run . -p // Welcome to gomacro. Type :help for help, :copy for copyright and license. // This is free software with ABSOLUTELY NO WARRANTY. gomacro> ``` to verify things work when no prompt is actually specified. (`-p` is just ignored in that case, similar to the existing behavior of `-e`).
csilvers
commented
Sep 21, 2023
| @@ -69,7 +69,7 @@ func (cmd *Cmd) Main(args []string) (err error) { | |||
| g := &ir.Comp.Globals | |||
|
|
|||
| var set, clear Options | |||
| var repl, forcerepl = true, false | |||
| repl, forcerepl := true, false | |||
There was a problem hiding this comment.
(This was my editor auto-fixing things. I can revert if you'd like.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have users who want to customize what the prompt looks like, to include things like the git repo they are running in.
Test plan:
I ran:
I also did:
to verify things work when no prompt is actually specified. (
-pis just ignored in that case, similar to the existing behavior of-e).