-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(x/consensus): harden consensus params proposal #20381
Conversation
Co-authored-by: Marko <marko@baricevic.me>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a changelog?
I the rationale: it is consensus breaking but as the chain would have halted if that wrongly gov proposal were submitted, we consider it safe to backport?
I need to spend some time seeing if it's breaking. I think the current design is fine but need to check as well |
I think compared to other consensus breaking where the chain would have panicked immediately, this will require a rollback of the latest block for those crashing, instead of simply switching binaries. However you could predict this issue is going to reach a chain miles ahead, as it is via a proposal. |
I think it's ok to backport to 0.50 even if it is consensus breaking. |
Seems like some tests are failing: https://github.com/cosmos/cosmos-sdk/actions/runs/9079625767/job/24949587121?pr=20381 |
Description
replaces: #20314
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...