chore: copyloopvar

[faddat]

Description

Adds the copyloopvar linter, and uses it.

Also adds a few newer linters, that didn't make any findings but would be good to have:

• canonicalheader
• mirror
• promlinter

Also updates go in CI to v1.22.3 everywhere, and sets each go.mod's minimum go to 1.22.2

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[coderabbitai]

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

99 files out of 156 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[faddat]

This seems to get around the issue with gomod2nix by referring tothe latest commit when we build it.

...nope

[yihuang]

this script need to change a little bit:

if command -v nix &> /dev/null
then
    nix develop .. -c gomod2nix
else
    if ! command -v gomod2nix &> /dev/null
    then
        # install gomod2nix manually
        echo "gomod2nix could not be found in PATH, installing..."
        go install github.com/nix-community/gomod2nix@master
    fi
    gomod2nix
fi

[yihuang]

the nix develop version should be more stable, because it also setup correct go version according to configs in go.mod.

[faddat]

Awesome, thank you! I'll get your changes in in a little bit :)

[tac0turtle]

Please revert all go.mod changes we are a library so bumping this number that often should be done

[faddat]

It's a "both" situation.

copyloopvar requires go > 1.22 in go.mod or its magic can't work

[tac0turtle]

Please revert the go mod changes. We won't accept the pr as it currently stands

[faddass]

Can you make the lint green @faddat

[julienrbrt]

copyloopvar requires go > 1.22 in go.mod or its magic can't work

Right, as that behavior only happens from 1.22: https://go.dev/blog/loopvar-preview
If the linter cannot determine if a package has a lower version than 1.22 and skips its logic, then we should just not add that copyloopvar linter.

[tac0turtle]

closing due to staleness