Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for cluster_KSLabel.tsv' #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

peterzh
Copy link

@peterzh peterzh commented Apr 1, 2020

Here I added support for loading cluster_KSLabel.tsv

@peterzh peterzh linked an issue Apr 1, 2020 that may be closed by this pull request
@nsteinme
Copy link
Collaborator

nsteinme commented Apr 1, 2020

Any chance you are willing to go a step further while you're at it and add support for loading any tsv file that's found in the directory? It would need to do a bit of sanitizing, like checking that it loads, and checking that every entry in the first column is a valid cluster ID (that would be a great check to add for cluster_group and cluster_KSLabel, too). I think ideally all tsv's besides cluster_group should go into a table together, with each becoming a column, rows for cluster IDs. Basically a table that looks like the clusterview in phy. What do you think?

@peterzh
Copy link
Author

peterzh commented Apr 15, 2020

Sure I can code that up. I'm confused as to why 'cluster_group' should not be in a table with the other cluster_* files though

@peterzh
Copy link
Author

peterzh commented Apr 15, 2020

I've started working on this code, and I have another question about the current loadKSdir code:

In line 27 the code loads spike_clusters.npy into 'clu'. In line 72 this variable is then overwritten with spikeTemplates, if no cluster groups file is found. I was wondering why this happens? Why not keep clu as it is, and not overwrite with spikeTemplates?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadKSDir doesn't load cluster label file 'cluster_KSLabel.tsv'
2 participants