Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to AWS Go SDK v2 #6588

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Port to AWS Go SDK v2 #6588

wants to merge 1 commit into from

Conversation

skitt
Copy link
Contributor

@skitt skitt commented Apr 5, 2024

1. Why is this pull request needed and what does it do?

v1 is deprecated, and support will end a little over a year from now. This ports the route53 plugin to v2.

The major difference is that listing resource records no longer uses a callback function; the results are retrieved directly, but paging has to be handled by the caller.

This hasn’t been tested on AWS yet.

2. Which issues (if any) are related?

None.

3. Which documentation changes (if any) need to be made?

None.

4. Does this introduce a backward incompatible change or deprecation?

None.

plugin/route53/setup.go Outdated Show resolved Hide resolved
v1 is deprecated, and support will end a little over a year from now.
This ports the route53 plugin to v2.

The major difference is that listing resource records no longer uses a
callback function; the results are retrieved directly, but paging has
to be handled by the caller.

This hasn’t been tested on AWS yet.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 55.81395% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 59.19%. Comparing base (93c57b6) to head (12d7061).
Report is 1158 commits behind head on master.

Files Patch % Lines
plugin/route53/setup.go 36.84% 10 Missing and 2 partials ⚠️
plugin/route53/route53.go 70.83% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6588      +/-   ##
==========================================
+ Coverage   55.70%   59.19%   +3.48%     
==========================================
  Files         224      252      +28     
  Lines       10016    13487    +3471     
==========================================
+ Hits         5579     7983    +2404     
- Misses       3978     4909     +931     
- Partials      459      595     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant