Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/ready: fix Reset list of readiness plugins #6577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yangjunmyfm192085
Copy link

1. Why is this pull request needed and what does it do?

When ready starts, it adds all implementors of readiness to its list of plugins to check for readiness.
We need to clears out the list, on every reload (such as kubernetes).

However, the current method of clears out the list is placed in the c.OnStartup function, which causes each plug-in to be cleared out, and there will be only one plug-in in the final list.

2. Which issues (if any) are related?

3. Which documentation changes (if any) need to be made?

4. Does this introduce a backward incompatible change or deprecation?

Signed-off-by: 杨军10092085 <yang.jun22@zte.com.cn>
@yangjunmyfm192085
Copy link
Author

/cc @chrisohaver

@chrisohaver
Copy link
Member

I'm not clear on precisely what is currently broken.

@yangjunmyfm192085
Copy link
Author

For example, there are two plug-ins, plugin1 and plugin2, both requiring readiness checks, but according to the current implementation, only one plug's readiness check will take effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants