Refactor plugin scrape test #6535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
requested review from
miekg,
chrisohaver,
johnbelamaric,
yongtang,
stp-ip,
bradbeam,
dilyevsky,
jameshartig,
greenpau,
Isolus,
pmoroney,
rajansandeep and
Tantalor93
as code owners
Replace retired[0] pbutil library with protodelim package. [0]: https://matttproud.com/blog/posts/retiring-pbutil.html Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/refactor_pbutil
branch
from
0d3be5b
to
bcd0f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Replace retired0 pbutil library with protodelim package.
2. Which issues (if any) are related?
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?