Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Don't copy back or forward EDNS query options #6415

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gcs278
Copy link
Contributor

@gcs278 gcs278 commented Nov 21, 2023

WIP

TODO:

  • Need to filter out EDNS OPTs on forward (hop-by-hop)
  • Unit testing
  • Proper reference of RFCs for motivation
  • Understand why rewrite plugin was adding EDNS in rewrite plugin config back to response
  • Investigate: bufsize shouldn't be copied from query to response

Related RFCs:

1. Why is this pull request needed and what does it do?

Doesn't copy query EDNS Options to response and doesn't forward them either.

2. Which issues (if any) are related?

#6188

3. Which documentation changes (if any) need to be made?

TBD

4. Does this introduce a backward incompatible change or deprecation?

TBD

@gcs278 gcs278 changed the title WIP: Don't copy back OPT RRs WIP: Don't copy query OPT to response Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 766 lines in your changes are missing coverage. Please review.

Comparison is base (93c57b6) 55.70% compared to head (f354459) 58.49%.
Report is 1104 commits behind head on master.

❗ Current head f354459 differs from pull request most recent head 922e565. Consider uploading reports for the commit 922e565 to get more accurate results

Files Patch % Lines
core/dnsserver/server_quic.go 9.13% 177 Missing and 2 partials ⚠️
core/dnsserver/register.go 0.00% 93 Missing ⚠️
core/dnsserver/server.go 15.05% 72 Missing and 7 partials ⚠️
plugin/backend_lookup.go 0.00% 37 Missing ⚠️
plugin/forward/dnstap.go 0.00% 30 Missing ⚠️
plugin/dnstap/setup.go 76.59% 17 Missing and 5 partials ⚠️
core/dnsserver/quic.go 23.07% 20 Missing ⚠️
plugin/forward/setup.go 72.05% 15 Missing and 4 partials ⚠️
plugin/dnssec/cache.go 32.00% 17 Missing ⚠️
core/dnsserver/onstartup.go 30.00% 14 Missing ⚠️
... and 43 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6415      +/-   ##
==========================================
+ Coverage   55.70%   58.49%   +2.79%     
==========================================
  Files         224      251      +27     
  Lines       10016    16566    +6550     
==========================================
+ Hits         5579     9690    +4111     
- Misses       3978     6283    +2305     
- Partials      459      593     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gcs278 gcs278 force-pushed the ends0-headers-no-copy branch 3 times, most recently from d6a1ba4 to f354459 Compare December 15, 2023 21:29
@gcs278 gcs278 changed the title WIP: Don't copy query OPT to response WIP: Don't copy back or forward EDNS query options Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant