Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase PHP platform config version #561

Open
wants to merge 7 commits into
base: 3.0
Choose a base branch
from
Open

Conversation

ericp-mrel
Copy link

  • Increase php version in composer platform.php config value so we can install the latest version of orchestra testbench.
  • Replace deprecated faker library with support library.

Updating testbench allows this package to maintain compatibility with the latest version of Laravel 6 since Laravel 6 requires PHP >= 7.2.5 and setting composer php platform version to 7.2 does not meet that requirement, so increasing the value allows everything to continue working.

Increase php version in composer platform.php config.
replace deprecated faker library with support library.
@ericp-mrel
Copy link
Author

Any chance you can merge this?

@bumbummen99
Copy link
Contributor

7.2 is EOL anyways, it might be good to remove it:
https://www.php.net/supported-versions.php

@ericp-mrel
Copy link
Author

7.2 is EOL anyways, it might be good to remove it:
https://www.php.net/supported-versions.php

Could also remove the platform override all together from the composer.json file so that the developer's current PHP version is used instead. Not sure if @jgrossi would be good with that?

@jgrossi
Copy link
Member

jgrossi commented Sep 30, 2021

hey folks 👋 corcel 3 e ~ laravel 6, that requires PHP 7.2.5+. I think we should stay with that. @ericp-mrel can you update this PR with last changes from the original branch please? thanks

@ericp-mrel
Copy link
Author

@jgrossi I'm not seeing any commits needing to be merged in from the original 3.0 branch. It's showing my branch as being 1 commit ahead and not behind by any.

@jgrossi
Copy link
Member

jgrossi commented Sep 30, 2021

"hautelook/phpass": "0.3.*", package was deleted. check 4.0 and 5.0 branches please.

if you can help with that on branch 3.0 would be great 🙏

@ericp-mrel
Copy link
Author

@jgrossi Gotcha.

Also, would you like me to remove the config.platform.php setting from the composer.json file, looks like the other branches no longer define a php platform version and wasn't sure if you'd like this branch to follow those newer branches.

@ericp-mrel
Copy link
Author

@jgrossi Any chance of merging? I'm not sure why this is taking so long.

I would like to get this merged so I don't have to keep maintaining my fork just to be able to install with L6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants