New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase PHP platform config version #561
base: 3.0
Are you sure you want to change the base?
Conversation
Increase php version in composer platform.php config. replace deprecated faker library with support library.
Any chance you can merge this? |
7.2 is EOL anyways, it might be good to remove it: |
Could also remove the platform override all together from the composer.json file so that the developer's current PHP version is used instead. Not sure if @jgrossi would be good with that? |
hey folks 👋 corcel 3 e ~ laravel 6, that requires PHP 7.2.5+. I think we should stay with that. @ericp-mrel can you update this PR with last changes from the original branch please? thanks |
@jgrossi I'm not seeing any commits needing to be merged in from the original 3.0 branch. It's showing my branch as being 1 commit ahead and not behind by any. |
if you can help with that on branch 3.0 would be great 🙏 |
@jgrossi Gotcha. Also, would you like me to remove the |
@jgrossi Any chance of merging? I'm not sure why this is taking so long. I would like to get this merged so I don't have to keep maintaining my fork just to be able to install with L6. |
# Conflicts: # composer.json # composer.lock
Updating testbench allows this package to maintain compatibility with the latest version of Laravel 6 since Laravel 6 requires PHP >= 7.2.5 and setting composer php platform version to 7.2 does not meet that requirement, so increasing the value allows everything to continue working.