Fix PHP Error when Term Taxonomy points to non-existing term_id #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasus
force-pushed
the
handle_corrupted_terms
branch
from
1c953d6
to
ba54c55
Compare
kasus
force-pushed
the
handle_corrupted_terms
branch
2 times, most recently
from
a1663c7
to
674bf6e
Compare
|
hey @kasus all good to me. can you just fix this conflict with the |
kasus
force-pushed
the
handle_corrupted_terms
branch
from
674bf6e
to
9dd2d38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If term has been deleted from
termstable but reference to it left interm_taxonomytable, it throws a PHP error when trying to reach$post->termsattribute.Since there are no foreign keys in WP tables, additional checking in code is needed.
Steps To Reproduce:
PHPUnit test is included in commit.
Create a Taxonomy with term_id = 0 and attach to the Post, try to get $post->terms attribute.