Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to make easier to add terms to post #425

Open
wants to merge 11 commits into
base: 2.7
Choose a base branch
from

Conversation

jgrossi
Copy link
Member

@jgrossi jgrossi commented Nov 13, 2018

This PR adds a addTerm(string $taxonomy, string $term) method to the Post model.

It partially fixes issue #410.

This way you don't have to worry about relations when adding terms to a given post:

$post = Post::find(1);
$term_instance = $post->addTerm('foo', 'Foo Term'); // "Foo Term" slug would be "foo-term"

馃敟馃槑

@kushsharma
Copy link

Hi, can you pull this up? @jgrossi
The code looks fine other than a merge conflict as those helpers would be really useful.

@jgrossi
Copy link
Member Author

jgrossi commented May 17, 2019

hey @kushsharma gonna try to fix conflicts today or tomorrow, merge it and release a new version. probably gonna change the repo from 2.7 to 2.8, the current one. cheers

@gumbophp
Copy link

gumbophp commented Sep 3, 2020

any updates on this?

@marcpre
Copy link

marcpre commented Dec 10, 2020

Any update on this method?

@gumbophp
Copy link

gumbophp commented Apr 9, 2021

So why is this still pending
1 year ago I really needed this functionality into corcel
If anything I can fork it and fix the things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants