Fixed MenuItem parent #383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f menu items points to the parent menu item, not the parent item's post/page
jgrossi
requested changes
May 29, 2018
README.md
Outdated
| @@ -609,14 +609,15 @@ foreach ($menu->items as $item) { | |||
|
|
|||
| To handle multi-levels menus, loop through all the menu items to put them on the right levels, for example. | |||
|
|
|||
| You can use the `MenuItem::parent()` method to retrieve the parent instance of that menu item: | |||
| You can use the `MenuItem::parent_item()` relation to retrieve the parent instance of that menu item: | |||
There was a problem hiding this comment.
can you change it to parentItem() to follow PSR-2, please?
README.md
Outdated
|
|
||
| ```php | ||
| $items = Menu::slug('foo')->first()->items; | ||
| $parent = $items->first()->parent(); // Post, Page, CustomLink or Term (category) | ||
| $parentItem = $items->first()->parent_item; // MenuItem or null for top-level items |
src/Model/MenuItem.php
Outdated
| */ | ||
| public function parent() | ||
| public function parent_item() |
|
done! cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the MenuItem parent relation using laravel belongsTo relation. Also fixed the tests, a menu item's parent id (in _menu_item_menu_item_parent) contains the id of the parent menu item, not the parent's linked post/page/etc.
I left the original parent() method there (which still points to the parent's post/page), so it should not break any implementations, just marked it as deprecated.
This should also fix #365
I can send a pull request for 2.6 after the other menu item pr is merged, otherwise it gets too confusing ;)