Added WordPress post formatting #2

[mforcer]

I have updated my pull request.

(I'm not sure why my push didn't update original pull request #254 - Maybe because I changed from master to dev?)

Let me know your thoughts.

If all is good we can close the old pull request.

Thanks

[jgrossi]

Hi @goodbytes-gb thanks for the hard work. I'm going to take a look on this and give you a feedback. Thanks!

[omzy]

Is this good to go? We definitely need it to automatically insert p tags when outputting content from posts table!

[jgrossi]

@goodbytes-gb can you fix this last conflict, please?

[Dartui]

@goodbytes-gb When WordPress is formatting code, before or after parsing shortcodes?

[mforcer]

@Dartui Currently it grabs post content with already parsed shortcodes, then formats the output. (i.e. before)

[Dartui]

@goodbytes-gb This is a list of all default filters for the_content:

• add_filter( 'the_content', 'wptexturize' );
• add_filter( 'the_content', 'convert_smilies', 20 );
• add_filter( 'the_content', 'wpautop' );
• add_filter( 'the_content', 'shortcode_unautop' );
• add_filter( 'the_content', 'prepend_attachment' );
• add_filter( 'the_content', 'wp_make_content_images_responsive' );

After wpautop there is shortcode_unautop which I guess is missing in this PR and may cause some unexpected behaviour

What is more, please look at this:

// Shortcodes
add_filter( 'the_content', 'do_shortcode', 11 ); // AFTER wpautop()

[mforcer]

@Dartui Thanks for the info, will look into it now.

[mforcer]

@Dartui It appears I confused myself... On closer inspection, it looks like running 'shortcode_unautop' is not necessary as it specifically refers to shortcodes added from the WP side, which Corcel would never be able to process as it does not have access to the shortcode callbacks.

Corcel already handles processing of shortcodes that have been added from Corcels implementation.

I have slightly refactored and can now confirm shortcodes are processed after the post content is formatted.

Hope this makes sense.

[matthewscalf]

Will this be included in a release soon?

[jgrossi]

Once now we're working with different Laravel versions (L5.5 for Corcel 2.5, for example), I'm gonna add this to the 2.5 branch only. If anyone needs this to another Laravel version just send a new PR to that branch (for example for Laravel 5.4, branch 2.4). Ok?

[dominicbouffard]

Hello guys,

Any news on that PR? That would definitely help me, I need paragraphs!! 😄

Thanks

[jgrossi]

Hey, yep this PR's gonna be merged soon. I have been a little busy theses last months but this is gonna be merged shortly. Thanks for the patience. 😉

[DivineOmega]

This would be really useful for a project I'm working on. Can it be merged now, or is there more work needed?

[iteearmah]

+1

[rjsworking]

+1

[pechanxur]

Can it be merged now, or is there more work needed?

[stanwarri]

Will this support the new Wordpress editor - https://wordpress.org/gutenberg/ ?

[mforcer]

@stanwarri Probably not, it will need updating or may not be needed at all. Have not tested it yet.

[jgrossi]

@gdbytes gonna merge this PR ASAP. can you just merge the current 2.6 branch into yours? I don't have enough privileges to do that. then all tests are gonna pass I guess. thanks 😎

[mforcer]

@jgrossi can you advise how to achieve this? Thanks

[jgrossi]

@gdbytes hey thanks for answering. the point is we have changed some code during the time on 2.6 and now also 2.7. this is failing this PR, so it's important to merge the 2.6 branch into it. something like this:

• update your local 2.6 branch with the last updates in the main Corcel repo;
• merge it to the current branch you are (your PR, it's dev I think): git merge 2.6
• push the changes to your PR

if you need some help you can give me push permission to your dev branch, or ping me for a quick call or something like that.

thanks 👏👍

[mforcer]

@jgrossi thanks I am struggling with this, unfortunately, where is best to catch you? Skype?

[jgrossi]

hey @gdbytes feel free to ping me on skype: juninhogr or discord: jgrossi#7360. I'm online usually in the morning.

[mforcer]

@jgrossi I've contacted you on discord (lunah#1208) ... Apologies for the delay, I've been mega busy.

[PayteR]

This is still not merged due to 4 issues to fix?

[mforcer]

I believe @jgrossi was fixing the issues but nothing as of yet.

I'm not sure how viable this is now with Gutenberg, it hasn't been tested.

[PayteR]

Gutenberg block will not be generated by this, but at least it will be compatible with standard post_content filtered output. IMHO it should be merged and later it could be possible to implement Gutenberg blocks into this.

[Dartui]

@PayteR This is how Gutenberg post looks like: https://github.com/WordPress/gutenberg/blob/master/post-content.php. There is no need to additionally parse it.