Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event targent type erasure #1525

Merged
merged 6 commits into from Oct 27, 2023
Merged

Fix event targent type erasure #1525

merged 6 commits into from Oct 27, 2023

Conversation

Siedlerchr
Copy link
Collaborator

Bump to javafx 21
Fixes #1516

@github-actions
Copy link

Hi Siedlerchr,

Welcome to ControlsFX and thank you for taking time to contribute to this project.

We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ?

@github-actions github-actions bot added the CLA label Oct 20, 2023
@Siedlerchr
Copy link
Collaborator Author

Just signed the CLA

@credmond
Copy link
Contributor

@jperedadnr: could you please merge this?

@johanvos
Copy link

It seems to me the JDK version needs to be fixed as well. What is the expected target release? JavaFX 21 required Java 17 or later, hence bytecode version 61. I see a failure in the GA: class file has wrong version 61.0, should be 55.0 -> but 61 is the requirement for JavaFX 21.

@github-actions
Copy link

Hi Siedlerchr,

Welcome to ControlsFX and thank you for taking time to contribute to this project.

We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ?

@github-actions github-actions bot added the CLA label Oct 24, 2023
@Siedlerchr
Copy link
Collaborator Author

Updated to jdk 17 in the workflows now as well

@johanvos
Copy link

This looks good, builds for me locally now.

@Siedlerchr
change javafx version to 17 again,
d89420e 
adjust imports and copyright
@Siedlerchr
Copy link
Collaborator Author

addressed your changes

@abhinayagarwal abhinayagarwal merged commit dc172e7 into controlsfx:master Oct 27, 2023
2 checks passed
@Siedlerchr Siedlerchr deleted the fixEventTargetTypeErasure branch October 27, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinayagarwal abhinayagarwal abhinayagarwal approved these changes

Assignees
No one assigned
Labels
CLA CLA-VERIFIED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocompletion method clash with javafx 21 due to changed event signature
4 participants
@Siedlerchr @credmond @johanvos @abhinayagarwal