Fixing two resource bugs within the sample application. #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…linkLabel was looking for a style.css file that does not exist anywhere (and is probably not necessary). 2. HelloDialogs was attempting to refer to a parent directory; but this doesn't work as the developer expected in the context of a running JAR. E.g., getResource("."), getResource(".."), getResource("../.."), etc., all resolve to null. This is not the case when running in a non-JAR context.
|
Hi credmond, Welcome to ControlsFX and thank you for taking time to contribute to this project. We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ? |
credmond
changed the title
Done. |
Siedlerchr
approved these changes
Nov 1, 2023
abhinayagarwal
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing two resource bugs within the sample application.
HelloHyperlinkLabel was looking for a style.css file that does not exist anywhere (and is probably not necessary).
HelloDialogs was attempting to refer to a parent directory; but this doesn't work as the developer expected in the context of a running JAR. E.g., getResource("."), getResource(".."), getResource("../.."), etc., all resolve to null. This is not the case when running in a non-JAR context.
Easy to reproduce these using "gradle run" and trying to load the hyperlink demo, or the dialog pop with custom image demo; neither work currently.
Fixes #1527